Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: reduce too many pings #5528

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Server: reduce too many pings #5528

merged 3 commits into from
Sep 23, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 3, 2022 •
edited
Loading

Signed-off-by: Jack Yu [email protected]

What problem does this PR solve?

Issue Number: close pingcap/tidb#36861
Issue Number: close #5688

Problem Summary:
pingcap/tidb#17885 reduced parts of this kind of logs, it could still be found in v6.1.0. According to grpc/grpc#28830, it seems it is not fixed yet. So disable the external pings for tiflash.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
@jackysp jackysp mentioned this pull request Aug 15, 2022
Closed
12 tasks
@jackysp
Copy link
Member Author

jackysp commented Aug 24, 2022

PTAL @zanmato1984

@jackysp jackysp closed this Aug 29, 2022
@windtalker windtalker reopened this Sep 22, 2022
@windtalker
Copy link
Contributor

Reopen it since client-go disable PermitWithoutStream in tikv/client-go#574

windtalker
windtalker approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
yibin87
yibin87 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f178797

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 23, 2022

Coverage for changed files

Filename                                                                                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Server/FlashGrpcServerHolder.cpp         217                70    67.74%           8                 0   100.00%         158                31    80.38%          58                27    53.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                        217                70    67.74%           8                 0   100.00%         158                31    80.38%          58                27    53.45%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18324      7505             59.04%    214346  77151        64.01%

full coverage report (for internal network access only)

@windtalker
Copy link
Contributor

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 23, 2022

Coverage for changed files

Filename                                                                                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Server/FlashGrpcServerHolder.cpp         217                68    68.66%           8                 0   100.00%         158                30    81.01%          58                25    56.90%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                        217                68    68.66%           8                 0   100.00%         158                30    81.01%          58                25    56.90%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      7995             57.43%    219004  82556        62.30%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 23, 2022

Coverage for changed files

Filename                                                                                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Server/FlashGrpcServerHolder.cpp         217                68    68.66%           8                 0   100.00%         158                30    81.01%          58                25    56.90%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                        217                68    68.66%           8                 0   100.00%         158                30    81.01%          58                25    56.90%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      7989             57.46%    219004  82415        62.37%

full coverage report (for internal network access only)

@windtalker
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit cbf94a6 into pingcap:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@jackysp @ti-chi-bot @sre-bot @windtalker @yibin87